Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spacing around the equals for OS_API_URL #1288 #1289

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove spacing around the equals for OS_API_URL #1288 #1289

wants to merge 1 commit into from

Conversation

joshuadkitenge
Copy link
Collaborator

Description

The space around the equal is not the correct syntax and causes in when just to build for the full ims docker stack

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

@joshuadkitenge joshuadkitenge marked this pull request as ready for review February 5, 2025 16:52
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
730 1 729 1
View the full list of 1 ❄️ flaky tests 
src/common/attachments/uploadAttachmentsDialog.component.test.tsx > Upload attachment dialog > posts attachment metadata successfully

Flake rate in main: 57.14% (Passed 3 times, Failed 4 times)

Stack Traces | 1.39s run time 
TestingLibraryElementError: Unable to find an element with the display value: test description.

Ignored nodes: comments, script, style
<body
  class="uppy-Dashboard-isFixed"
>
  <div>
    <div
      class="uppy-Container"
    >
      <div
        class="uppy-Root"
        dir="ltr"
      >
        <div
          aria-disabled="false"
          aria-hidden="false"
          aria-label="Uppy Dashboard Window (Press escape to close)"
          class="uppy-Dashboard uppy-Dashboard--modal uppy-Dashboard--isInnerWrapVisible"
          data-uppy-drag-drop-supported="true"
          data-uppy-num-acquirers="0"
          data-uppy-theme="light"
        >
          <div
            aria-hidden="true"
            class="uppy-Dashboard-overlay"
            tabindex="-1"
          />
          <div
            aria-modal="true"
            class="uppy-Dashboard-inner"
            role="dialog"
          >
            <button
              aria-label="Close Modal"
              class="uppy-u-reset uppy-Dashboard-close"
              title="Close Modal"
              type="button"
            >
              <span
                aria-hidden="true"
              >
                ×
              </span>
            </button>
            <div
              class="uppy-Dashboard-innerWrap"
            >
              <div
                class="uppy-Dashboard-dropFilesHereHint"
              >
                Drop your files here
              </div>
              <div
                class="uppy-DashboardContent-bar"
              >
                <button
                  class="uppy-DashboardContent-back"
                  type="button"
                >
                  Cancel
                </button>
                <div
                  aria-level="1"
                  class="uppy-DashboardContent-title"
                  role="heading"
                >
                  1 file selected
                </div>
                <button
                  aria-label="Add more files"
                  class="uppy-DashboardContent-addMore"
                  title="Add more files"
                  type="button"
                >
                  <svg
                    aria-hidden="true"
                    class="uppy-c-icon"
                    focusable="false"
                    height="15"
                    viewBox="0 0 15 15"
                    width="15"
                  >
                    <path
                      d="M8 6.5h6a.5.5 0 0 1 .5.5v.5a.5.5 0 0 1-.5.5H8v6a.5.5 0 0 1-.5.5H7a.5.5 0 0 1-.5-.5V8h-6a.5.5 0 0 1-.5-.5V7a.5.5 0 0 1 .5-.5h6v-6A.5.5 0 0 1 7 0h.5a.5.5 0 0 1 .5.5v6z"
                    />
                  </svg>
                  <span
                    class="uppy-DashboardContent-addMoreCaption"
                  >
                    Add more
                  </span>
                </button>
              </div>
              <div
                class="uppy-Dashboard-files"
              >
                <div
                  class="uppy-Dashboard-filesInner"
                  role="presentation"
                >
                  <div
                    class="uppy-Dashboard-Item is-resumable"
                    id="uppy_uppy-test1/txt-1e-text/plain-4-1738793493757"
                    role="listitem"
                  >
                    <div
                      class="uppy-Dashboard-Item-preview"
                    >
                      <div
                        class="uppy-Dashboard-Item-previewInnerWrap"
                        style="background-color: rgb(90, 94, 105);"
                      >
                        <div
                          class="uppy-Dashboard-Item-previewIconWrap"
                        >
                          <span
                            class="uppy-Dashboard-Item-previewIcon"
                            style="color: rgb(90, 94, 105);"
                          >
                            <svg
                              aria-hidden="true"
                              class="uppy-c-icon"
                              focusable="false"
                              height="25"
                              viewBox="0 0 25 25"
                              width="25"
                            >
                              <path
                                d="M4.5 7h13a.5.5 0 1 1 0 1h-13a.5.5 0 0 1 0-1zm0 3h15a.5.5 0 1 1 0 1h-15a.5.5 0 1 1 0-1zm0 3h15a.5.5 0 1 1 0 1h-15a.5.5 0 1 1 0-1zm0 3h10a.5.5 0 1 1 0 1h-10a.5.5 0 1 1 0-1z"
                                fill="#5A5E69"
                                fillRule="nonzero"
                              />
                            </svg>
                          </span>
                          <svg
                            aria-hidden="true"
                            class="uppy-Dashboard-Item-previewIconBg"
                            focusable="false"
                            height="76"
                            viewBox="0 0 58 76"
                            width="58"
                          >...

Ignored nodes: comments, script, style
<body
  class="uppy-Dashboard-isFixed"
>
  <div>
    <div
      class="uppy-Container"
    >
      <div
        class="uppy-Root"
        dir="ltr"
      >
        <div
          aria-disabled="false"
          aria-hidden="false"
          aria-label="Uppy Dashboard Window (Press escape to close)"
          class="uppy-Dashboard uppy-Dashboard--modal uppy-Dashboard--isInnerWrapVisible"
          data-uppy-drag-drop-supported="true"
          data-uppy-num-acquirers="0"
          data-uppy-theme="light"
        >
          <div
            aria-hidden="true"
            class="uppy-Dashboard-overlay"
            tabindex="-1"
          />
          <div
            aria-modal="true"
            class="uppy-Dashboard-inner"
            role="dialog"
          >
            <button
              aria-label="Close Modal"
              class="uppy-u-reset uppy-Dashboard-close"
              title="Close Modal"
              type="button"
            >
              <span
                aria-hidden="true"
              >
                ×
              </span>
            </button>
            <div
              class="uppy-Dashboard-innerWrap"
            >
              <div
                class="uppy-Dashboard-dropFilesHereHint"
              >
                Drop your files here
              </div>
              <div
                class="uppy-DashboardContent-bar"
              >
                <button
                  class="uppy-DashboardContent-back"
                  type="button"
                >
                  Cancel
                </button>
                <div
                  aria-level="1"
                  class="uppy-DashboardContent-title"
                  role="heading"
                >
                  1 file selected
                </div>
                <button
                  aria-label="Add more files"
                  class="uppy-DashboardContent-addMore"
                  title="Add more files"
                  type="button"
                >
                  <svg
                    aria-hidden="true"
                    class="uppy-c-icon"
                    focusable="false"
                    height="15"
                    viewBox="0 0 15 15"
                    width="15"
                  >
                    <path
                      d="M8 6.5h6a.5.5 0 0 1 .5.5v.5a.5.5 0 0 1-.5.5H8v6a.5.5 0 0 1-.5.5H7a.5.5 0 0 1-.5-.5V8h-6a.5.5 0 0 1-.5-.5V7a.5.5 0 0 1 .5-.5h6v-6A.5.5 0 0 1 7 0h.5a.5.5 0 0 1 .5.5v6z"
                    />
                  </svg>
                  <span
                    class="uppy-DashboardContent-addMoreCaption"
                  >
                    Add more
                  </span>
                </button>
              </div>
              <div
                class="uppy-Dashboard-files"
              >
                <div
                  class="uppy-Dashboard-filesInner"
                  role="presentation"
                >
                  <div
                    class="uppy-Dashboard-Item is-resumable"
                    id="uppy_uppy-test1/txt-1e-text/plain-4-1738793493757"
                    role="listitem"
                  >
                    <div
                      class="uppy-Dashboard-Item-preview"
                    >
                      <div
                        class="uppy-Dashboard-Item-previewInnerWrap"
                        style="background-color: rgb(90, 94, 105);"
                      >
                        <div
                          class="uppy-Dashboard-Item-previewIconWrap"
                        >
                          <span
                            class="uppy-Dashboard-Item-previewIcon"
                            style="color: rgb(90, 94, 105);"
                          >
                            <svg
                              aria-hidden="true"
                              class="uppy-c-icon"
                              focusable="false"
                              height="25"
                              viewBox="0 0 25 25"
                              width="25"
                            >
                              <path
                                d="M4.5 7h13a.5.5 0 1 1 0 1h-13a.5.5 0 0 1 0-1zm0 3h15a.5.5 0 1 1 0 1h-15a.5.5 0 1 1 0-1zm0 3h15a.5.5 0 1 1 0 1h-15a.5.5 0 1 1 0-1zm0 3h10a.5.5 0 1 1 0 1h-10a.5.5 0 1 1 0-1z"
                                fill="#5A5E69"
                                fillRule="nonzero"
                              />
                            </svg>
                          </span>
                          <svg
                            aria-hidden="true"
                            class="uppy-Dashboard-Item-previewIconBg"
                            focusable="false"
                            height="76"
                            viewBox="0 0 58 76"
                            width="58"
                          >...
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../common/attachments/uploadAttachmentsDialog.component.test.tsx:112:20

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VKTB VKTB Awaiting requested review from VKTB

@joelvdavies joelvdavies Awaiting requested review from joelvdavies

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshuadkitenge