Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a production Docker image #107

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Create a production Docker image #107

merged 4 commits into from
Feb 3, 2025

Conversation

VKTB
Copy link
Collaborator

@VKTB VKTB commented Feb 3, 2025

Description

This PR refactors the Dockerfile so there is a dev stage that can be used to build an image for local development and a prod stage that can be used to build an image for production. It also adds a new docker job to the GitHub Actions CI file to build the production image and if the workflow is manually triggered while the push-docker-image-to-harbor input is set to true, to push it to Harbor.

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

connect to #5

@VKTB
Copy link
Collaborator Author

VKTB commented Feb 3, 2025

I manually triggered the workflow so there is now a production Docker image available on Harbor.

@VKTB VKTB marked this pull request as ready for review February 3, 2025 15:57
@VKTB VKTB requested a review from joelvdavies February 3, 2025 15:57
Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally and I can see it pushed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (eccc758) to head (4a58d43).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #107   +/-   ##
========================================
  Coverage    99.57%   99.57%           
========================================
  Files           19       19           
  Lines          468      468           
========================================
  Hits           466      466           
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VKTB VKTB merged commit 83ee024 into develop Feb 3, 2025
8 checks passed
@VKTB VKTB deleted the prod-docker-image-#5 branch February 3, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants