Updating loader-utils to v3.2.0 #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.80% // Head: 93.80% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #120 +/- ##
========================================
Coverage 93.80% 93.80%
========================================
Files 49 49
Lines 1793 1793
Branches 446 446
========================================
Hits 1682 1682
Misses 111 111 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
My conclusion is that this is fundamentally incompatible with some essential libraries we use, therefore I'm happy to stick with v2 which, while deprecated, is still heavily used in the community. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently had a couple of PRs on OperationsGateway and DataGateway created by Dependabot to resolve critical vulnerabilities recently discovered in v2 and v1 of loader-utils respectively. I have since merged both PRs but neither project is using the latest version of loader-utils.
This PR aims to address that by upgrading to v3. It may be I'm unaware of why we're using an older, deprecated version (perhaps it's still a transitive dependency for many of our dependencies) so if that's the case, we can close this PR. Otherwise, we can upgrade and consider doing the same with DataGateway.
Testing instructions
Check latest version is being used.
Agile board tracking
Hotfix