Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-350 Delete favourite filter #510

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

joshuadkitenge
Copy link
Contributor

Description

delete a favourite filter

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes DSEGOG-350

@joshuadkitenge joshuadkitenge force-pushed the DSEGOG-350-delete-favourite-filter branch from 2d47104 to 4255f88 Compare November 4, 2024 09:31
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (6b43c51) to head (b7a1140).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #510      +/-   ##
===========================================
+ Coverage    97.89%   97.90%   +0.01%     
===========================================
  Files           92       93       +1     
  Lines        12069    12153      +84     
  Branches      1903     1406     -497     
===========================================
+ Hits         11815    11899      +84     
  Misses         252      252              
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@joshuadkitenge joshuadkitenge marked this pull request as ready for review November 14, 2024 14:44
Base automatically changed from DSEGOG-349-edit-favourite-filter to develop November 20, 2024 10:17
- remove todos for mutations react query hooks
- use the favouriteFiltersJson to get the id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants