Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix help page top-of-page-icon link on help page #1400

Closed
1 task
joelvdavies opened this issue Jul 8, 2024 · 0 comments · Fixed by #1401
Closed
1 task

Fix help page top-of-page-icon link on help page #1400

joelvdavies opened this issue Jul 8, 2024 · 0 comments · Fixed by #1401
Assignees
@joelvdavies
Labels
bug Something isn't working

Comments

@joelvdavies
Copy link
Contributor

joelvdavies commented Jul 8, 2024 •
edited
Loading

Description:
The top of page icon links don't go to the top of the page - this seems to be due to #1121, as the link instead goes to the top of the viewport and so does nothing.

A simple fix appears to be adding an id to the help page div itself and then using that in the link rather than the scigateway div currently used in the example default.json.

Acceptance criteria:

  • Links work as expected
@joelvdavies joelvdavies added the bug Something isn't working label Jul 8, 2024
@joelvdavies joelvdavies self-assigned this Jul 8, 2024
joelvdavies added a commit that referenced this issue Jul 8, 2024
@joelvdavies
Fix help page top of page links #1400
7bc6b85
@joelvdavies joelvdavies mentioned this issue Jul 8, 2024
Merged
3 tasks
joelvdavies added a commit that referenced this issue Jul 8, 2024
@joelvdavies
Merge pull request #1401 from ral-facilities/fix-help-page-top-of-pag…
ed69019 
…e-links-#1400

Fix help page top of page links #1400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelvdavies joelvdavies

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix help page top of page links #1400 ral-facilities/scigateway
1 participant
@joelvdavies