Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dockerfile #1036

Merged
merged 13 commits into from
May 9, 2022
Merged

Create Dockerfile #1036

merged 13 commits into from
May 9, 2022

Conversation

VKTB
Copy link
Contributor

@VKTB VKTB commented Apr 19, 2022

Description

Creates a multipart build Dockerfile to build and deploy the SciGateway app on port 80.

Once #1026 is merged, I will modify the Dockerfile so that it performs a production installation.

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Successful production installation
  • Successful build
  • Successful HTTP server deployment

Agile board tracking

closes #1029

@VKTB VKTB requested a review from moonraker595 April 19, 2022 14:49
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1036 (ea62522) into k8s-deployment (d3f30b4) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           k8s-deployment    #1036   +/-   ##
===============================================
  Coverage           97.94%   97.94%           
===============================================
  Files                  42       42           
  Lines                1557     1557           
  Branches              411      422   +11     
===============================================
  Hits                 1525     1525           
  Misses                 31       31           
  Partials                1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f30b4...ea62522. Read the comment docs.

@VKTB VKTB deleted the branch k8s-deployment April 26, 2022 11:58
@VKTB VKTB closed this Apr 26, 2022
@VKTB VKTB reopened this Apr 26, 2022
@VKTB VKTB changed the base branch from feature/k8s-deployment to k8s-deployment April 26, 2022 12:15
VKTB and others added 2 commits April 26, 2022 12:31
@VKTB VKTB added the deployment label May 9, 2022
@VKTB VKTB merged commit 4d0fd3c into k8s-deployment May 9, 2022
@VKTB VKTB deleted the deployment/adding-docker-file-#1029 branch May 9, 2022 14:28
@VKTB VKTB mentioned this pull request May 20, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants