-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix token refresh error #1072
Merged
Merged
Fix token refresh error #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1072 +/- ##
===========================================
+ Coverage 97.93% 97.94% +0.01%
===========================================
Files 42 42
Lines 1551 1560 +9
Branches 417 418 +1
===========================================
+ Hits 1519 1528 +9
Misses 31 31
Partials 1 1
Continue to review full report at Codecov.
|
- it logs an error and displays an error notification to the user - this fixes the flaky e2e test
sam-glendenning
suggested changes
May 25, 2022
- they're dg translations from when I was working on another issue
sam-glendenning
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Goes with ral-facilities/datagateway#1262
Allow plugins to send a notification payload alongside their token invalidation request event, which we then only display after the token refresh has failed.
Testing instructions
Agile board tracking
Part of the fix for ral-facilities/datagateway#1257