Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token refresh error #1072

Merged
merged 6 commits into from
May 27, 2022
Merged

Conversation

louise-davies
Copy link
Member

Description

Goes with ral-facilities/datagateway#1262

Allow plugins to send a notification payload alongside their token invalidation request event, which we then only display after the token refresh has failed.

Testing instructions

Agile board tracking

Part of the fix for ral-facilities/datagateway#1257

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1072 (17d8a69) into develop (4660cc7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1072      +/-   ##
===========================================
+ Coverage    97.93%   97.94%   +0.01%     
===========================================
  Files           42       42              
  Lines         1551     1560       +9     
  Branches       417      418       +1     
===========================================
+ Hits          1519     1528       +9     
  Misses          31       31              
  Partials         1        1              
Impacted Files Coverage Δ
src/state/middleware/scigateway.middleware.tsx 93.23% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4660cc7...17d8a69. Read the comment docs.

- it logs an error and displays an error notification to the user
- this fixes the flaky e2e test
- they're dg translations from when I was working on another issue
@louise-davies louise-davies merged commit 2608a1a into develop May 27, 2022
@louise-davies louise-davies deleted the bugfix/fix-token-refresh-error branch June 6, 2022 13:38
@louise-davies louise-davies added the bug Something isn't working label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants