Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1086 - enable custom logos to be larger than 24px #1090

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

louise-davies
Copy link
Member

Description

Instead, we just set a sensible max height based off of the app bar height. Default logos I set to be 24px height instead so we don't have to modify the SVGs to be smaller.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #1086

- & just set a sensible max height based off of the app bar height
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1090 (224b313) into develop (9d5c7a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1090      +/-   ##
===========================================
+ Coverage    97.95%   97.97%   +0.01%     
===========================================
  Files           42       42              
  Lines         1565     1577      +12     
  Branches       420      423       +3     
===========================================
+ Hits          1533     1545      +12     
  Misses          31       31              
  Partials         1        1              
Impacted Files Coverage Δ
src/mainAppBar/mainAppBar.component.tsx 100.00% <100.00%> (ø)
src/state/scigateway.types.tsx 100.00% <0.00%> (ø)
src/state/reducers/scigateway.reducer.tsx 100.00% <0.00%> (ø)
src/state/middleware/scigateway.middleware.tsx 93.23% <0.00%> (ø)
src/state/actions/scigateway.actions.tsx 98.18% <0.00%> (+0.03%) ⬆️
src/theming.tsx 97.05% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5c7a5...224b313. Read the comment docs.

@louise-davies louise-davies merged commit e04313c into develop Jun 13, 2022
@louise-davies louise-davies deleted the feature/bigger-logo-#1086 branch June 13, 2022 14:59
@louise-davies louise-davies added the enhancement New feature or request label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLS logo needs to be bigger in mainAppBar
2 participants