Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed footer to include SCD #1164

Merged
merged 6 commits into from
Oct 24, 2022
Merged

Conversation

LunaBarrett
Copy link
Contributor

Description

Changed over footer to include SCD

Agile board tracking

connect to #1039

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Base: 96.74% // Head: 96.76% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (dea2681) compared to base (e87463b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1164      +/-   ##
===========================================
+ Coverage    96.74%   96.76%   +0.02%     
===========================================
  Files           43       43              
  Lines         1598     1609      +11     
  Branches       436      437       +1     
===========================================
+ Hits          1546     1557      +11     
  Misses          48       48              
  Partials         4        4              
Impacted Files Coverage Δ
src/footer/footer.component.tsx 100.00% <ø> (ø)
src/routing/authorisedRoute.component.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@agbeltran
Copy link
Member

@LunaBarrett could you please address the merge conflicts here? cc @louise-davies

Merge branch 'develop' into Footer-change-to-mention-SCD-#1039

Signed-off-by: jounaidr <jounaidruhomaun@googlemail.com>

# Conflicts:
#	src/footer/footer.component.tsx
Signed-off-by: jounaidr <jounaidruhomaun@googlemail.com>
Signed-off-by: jounaidr <jounaidruhomaun@googlemail.com>
Signed-off-by: jounaidr <jounaidruhomaun@googlemail.com>
@jounaidr
Copy link
Contributor

Additional changes:

  • Merge conflicts fixed
  • Trans component fixed so both links are rendered correctly

See:
chrome_o0ejuFYJsw

Think this is now ready for review @louise-davies :)

@jounaidr jounaidr linked an issue Oct 20, 2022 that may be closed by this pull request
1 task
@jounaidr jounaidr merged commit 205cb46 into develop Oct 24, 2022
@jounaidr jounaidr deleted the Footer-change-to-mention-SCD-#1039 branch October 24, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer change to mention SCD
4 participants