Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating yarn.lock to remove unnecessary package #1195

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

sam-glendenning
Copy link
Contributor

@sam-glendenning sam-glendenning commented Sep 28, 2022

Description

The package is functional-red-black-tree. This seemed to occur when I merged the package update to eslint. See the job output here: https://github.com/ral-facilities/scigateway/actions/runs/3135039062/jobs/5105040029

Testing instructions

The CI tests should pass

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

Hotfix

@sam-glendenning sam-glendenning added the bug Something isn't working label Sep 28, 2022
@sam-glendenning sam-glendenning changed the title Updating yarn.lock to include missing package Updating yarn.lock to remove unnecessary package Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 96.74% // Head: 96.74% // No change to project coverage 👍

Coverage data is based on head (d9bc712) compared to base (faa080a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1195   +/-   ##
========================================
  Coverage    96.74%   96.74%           
========================================
  Files           43       43           
  Lines         1598     1598           
  Branches       436      436           
========================================
  Hits          1546     1546           
  Misses          48       48           
  Partials         4        4           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sam-glendenning sam-glendenning merged commit 940fb9c into develop Sep 28, 2022
@sam-glendenning sam-glendenning deleted the fixing-yarn.lock-file branch September 28, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants