-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate scigateway tests to testing-library #1273
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1273 +/- ##
===========================================
+ Coverage 96.76% 97.01% +0.24%
===========================================
Files 43 43
Lines 1609 1609
Branches 437 437
===========================================
+ Hits 1557 1561 +4
+ Misses 48 45 -3
+ Partials 4 3 -1
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
- also remove the use of jest legacy fake timers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good other than my minor comment. I added a couple of commits to 1) remove the spam from the test console I found when I ran the tests locally and 2) to recreate the test you skipped in App.test.tsx. Let me know your thoughts on my changes :)
…enhancement/rtl-migration
Description
This PR migrates every unit tests scigateway to testing-library. I also improved some of the existing tests as well.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
connect to #1265