React 18 #1205 #1275
Draft
React 18 #1205 #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also, upgrade other libraries to support react 18 and fix anything that broke immediately
Plus some misc styling fixes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1275 +/- ##
===========================================
- Coverage 96.77% 96.76% -0.02%
===========================================
Files 48 48
Lines 1739 1763 +24
Branches 492 497 +5
===========================================
+ Hits 1683 1706 +23
- Misses 52 53 +1
Partials 4 4 ☔ View full report in Codecov by Sentry. |
1 task
joelvdavies
reviewed
Jan 23, 2024
Otherwise redirect to logout page
louise-davies
force-pushed
the
react-18-#1205
branch
from
72a5d9b
to
2a6cabb
Compare
…heming-#357 add darkBlue colour to theming
Co-authored-by: Joel Davies <90245114+joelvdavies@users.noreply.github.com>
Co-authored-by: Joel Davies <90245114+joelvdavies@users.noreply.github.com>
…ilty-#355 Increase toast functionailty #355
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1275 +/- ##
===========================================
+ Coverage 96.78% 96.95% +0.17%
===========================================
Files 48 49 +1
Lines 1740 1775 +35
Branches 485 497 +12
===========================================
+ Hits 1684 1721 +37
+ Misses 52 50 -2
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Print improvement for IMS
…le-names-on-the-accessibility-page-#356
…he-varaiable-names-on-the-accessibility-page-#356 Change accessibility page variable to be more general #356
…stency-for-ims Fix error colour inconsistency for IMS
* implemented changes to fetch maintenance states from ldap endpoints * removed jest.mock and renamed class * added tests for scheduled maintenance endpoint * corrected class name in reducer * renamed files and improved code coverage * renamed import in scigateway.reducer * renamed import in test * changed function that is called in test * uncommit file change * renamed variable, improved code coverage * renamed files * moved testing of ldap-jwt within test
|
We should ensure that for IMS the docker GA job builds images for tags for when we do the proper release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to React 18, fix issues with integration with OG and also some misc fixes/adjustments
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1205