Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deneb (EIP-4844) types and presets #170

Merged
merged 20 commits into from
Jul 16, 2023
Merged

Add Deneb (EIP-4844) types and presets #170

merged 20 commits into from
Jul 16, 2023

Conversation

jimmygchen
Copy link
Contributor

@jimmygchen jimmygchen commented Jan 16, 2023 •
edited
Loading

No description provided.

@ralexstokes ralexstokes mentioned this pull request Jan 19, 2023
Closed
3 tasks
ralexstokes
ralexstokes reviewed Jan 19, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to focus on #168 first but I skimmed this

directionally, it looks good!

src/kzg.rs Outdated Show resolved Hide resolved
src/kzg.rs Outdated Show resolved Hide resolved
src/kzg.rs Outdated Show resolved Hide resolved
ralexstokes
ralexstokes reviewed Jan 19, 2023
View reviewed changes
src/kzg.rs Outdated Show resolved Hide resolved
@jimmygchen
Copy link
Contributor Author

Will revisit this PR once the spec changes for decoupling blobs (https://hackmd.io/cmYisgxkRuGe9NjX4gr97A?view) is closer to ready.

@jimmygchen
Copy link
Contributor Author

Hi @ralexstokes
I have made another update:

ralexstokes
ralexstokes reviewed Feb 16, 2023
View reviewed changes
src/configs/sepolia.rs Outdated Show resolved Hide resolved
ralexstokes
ralexstokes reviewed Feb 16, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice updates!

@jimmygchen
Merge branch 'main' into deneb-types-and-presets
d421d28
@jimmygchen
Merge branch 'main' into deneb-types-and-presets
ff52824 
# Conflicts:
#	src/configs/goerli.rs
#	src/configs/mainnet.rs
#	src/configs/sepolia.rs
jimmygchen
jimmygchen commented May 19, 2023
View reviewed changes
src/deneb/beacon_block.rs Outdated Show resolved Hide resolved
@jimmygchen
Copy link
Contributor Author

Hi @ralexstokes
I've updated this PR to the latest spec - please take another look 🙏
Cheers

ralexstokes
ralexstokes approved these changes Jul 16, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

I see what appear to be unnecessary generics on some of the blob types (e.g. params like BYTES_PER_BLOB)

that being said, I am doing some more extensive refactoring and want to just go ahead and merge this in to avoid excessive thrash from repo-wide change

if you run into some problem please feel free to open another PR

@ralexstokes ralexstokes merged commit 1728010 into ralexstokes:main Jul 16, 2023
2 checks passed
@jimmygchen jimmygchen deleted the deneb-types-and-presets branch July 17, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmygchen @ralexstokes