Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deneb: implement poly comm spec #225

Merged
merged 25 commits into from
Oct 12, 2023
Merged

deneb: implement poly comm spec #225

merged 25 commits into from
Oct 12, 2023

Conversation

EchoAlice
Copy link
Contributor

Fixes #224

@EchoAlice EchoAlice changed the title Create initial polynomial commitments spec deneb: implement poly comm spec Sep 7, 2023
ralexstokes
ralexstokes reviewed Sep 21, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left some comments

ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
@EchoAlice EchoAlice force-pushed the polynomial_commitments branch 4 times, most recently from 5cd8d41 to 3035232 Compare October 2, 2023 20:32
@EchoAlice EchoAlice marked this pull request as ready for review October 2, 2023 20:54
ralexstokes
ralexstokes requested changes Oct 5, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! left some comments for the direction to move in

ethereum-consensus/Cargo.toml Outdated Show resolved Hide resolved
ethereum-consensus/Cargo.toml Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
@EchoAlice EchoAlice force-pushed the polynomial_commitments branch 2 times, most recently from c63cb00 to 58d7bd0 Compare October 9, 2023 19:43
ralexstokes
ralexstokes requested changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great updates :)

ethereum-consensus/Cargo.toml Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs:61:49 Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ralexstokes
ralexstokes requested changes Oct 11, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there!

ethereum-consensus/Cargo.toml Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/state_transition/error.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ralexstokes
ralexstokes approved these changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent work!

ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/deneb/polynomial_commitments.rs Show resolved Hide resolved
@ralexstokes ralexstokes merged commit 8432749 into ralexstokes:main Oct 12, 2023
2 checks passed
EchoAlice
EchoAlice commented Oct 12, 2023
View reviewed changes
ethereum-consensus/src/deneb/polynomial_commitments.rs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to be less sloppy next time

@EchoAlice EchoAlice deleted the polynomial_commitments branch November 3, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deneb: implement poly comm spec
2 participants
@EchoAlice @ralexstokes