Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add network type #230

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: add network type #230

merged 2 commits into from
Sep 13, 2023

Conversation

chirag-bgh
Copy link
Contributor

Closes #227

ralexstokes
ralexstokes requested changes Sep 13, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

one change to make this maximally re-useable

next will be to update mev-rs to use this new type here

ethereum-consensus/src/networks.rs Outdated Show resolved Hide resolved
ralexstokes
ralexstokes approved these changes Sep 13, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

I think we may need to move that TryFrom<&Network> for Context impl but we can do that when we refactor mev-rs

@ralexstokes ralexstokes merged commit 6dee239 into ralexstokes:main Sep 13, 2023
2 checks passed
@chirag-bgh chirag-bgh mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stronger typing for Networks concept
2 participants
@chirag-bgh @ralexstokes