Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create benchmarks for proof generation and verification #162

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

EchoAlice
Copy link
Contributor

Addresses issue #160

@EchoAlice
Copy link
Contributor Author

i'm getting warnings about code unrelated to the PR which is making the build check not pass. Should i fix these warnings?

@ralexstokes
Copy link
Owner

looks like the issue is directly related to this PR

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> ssz-rs/src/lib.rs:86:12
   |
86 | #![feature(test)]
   |            ^^^^

For more information about this error, try `rustc --explain E0554`.

and it seems like the issue is that the "native" rustc support for benchmarks is not on a stable version of the compiler yet

it looks like a common alternative is Criterion, e.g https://github.com/bheisler/criterion.rs?tab=readme-ov-file#quickstart

I think it will also be nicer if we have the benchmarks collected outside of the src files, say in a top-level benches directory

@EchoAlice
Copy link
Contributor Author

looks like the issue is directly related to this PR

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> ssz-rs/src/lib.rs:86:12
   |
86 | #![feature(test)]
   |            ^^^^

For more information about this error, try `rustc --explain E0554`.

and it seems like the issue is that the "native" rustc support for benchmarks is not on a stable version of the compiler yet

it looks like a common alternative is Criterion, e.g https://github.com/bheisler/criterion.rs?tab=readme-ov-file#quickstart

I think it will also be nicer if we have the benchmarks collected outside of the src files, say in a top-level benches directory

This was what i was referring to:

warning: the item `Ordering` is imported redundantly
   --> ssz-rs/src/list.rs:337:17
    |
336 |     use super::*;
    |         -------- the item `Ordering` is already imported here
337 |     use crate::{lib::cmp::Ordering, serialize, U256};
    |                 ^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

ssz-rs/src/lib.rs Outdated Show resolved Hide resolved
@ralexstokes
Copy link
Owner

looks like the issue is directly related to this PR

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> ssz-rs/src/lib.rs:86:12
   |
86 | #![feature(test)]
   |            ^^^^

For more information about this error, try `rustc --explain E0554`.

and it seems like the issue is that the "native" rustc support for benchmarks is not on a stable version of the compiler yet
it looks like a common alternative is Criterion, e.g https://github.com/bheisler/criterion.rs?tab=readme-ov-file#quickstart
I think it will also be nicer if we have the benchmarks collected outside of the src files, say in a top-level benches directory

This was what i was referring to:

warning: the item `Ordering` is imported redundantly
   --> ssz-rs/src/list.rs:337:17
    |
336 |     use super::*;
    |         -------- the item `Ordering` is already imported here
337 |     use crate::{lib::cmp::Ordering, serialize, U256};
    |                 ^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

I see a different error, need to update the MSRV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants