feat: implement multiproof generation #171
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123
An alternative implementation to #157 to only build the tree once when generating multi proofs.
Would it be more ergonomic to change the API and decoupling tree building from proof generation to make implementation more modular and easier to benchmark? The way the code is currently structured if you wanna create a proof and then a multiproof you need to build the tree twice. Alternatively the tree itself could be cached.
Merkleproofs had no tests, so I added some basic ones to make sure I don't break it too bad while optimizing.
Most of the time is spent on building the tree, not generating the proofs themselves, so stacking #169 and #170 should get down to less than 30ms: