Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of errors in places expecting E: std::error::Error #46

Merged
merged 4 commits into from
Jan 30, 2023

Conversation

ralexstokes
Copy link
Owner

@ralexstokes ralexstokes commented Jan 27, 2023

something dropped in #25 was impl Error for all the various error types

I think we can just declare an impl for the std context and call it day. Update: this was the route taken.

While working on this a few other updates arrived:

  1. Expose Instance and Type errors to simplify error UX for consumers
  2. remove the problematic FromIterator impl for List and Vector
  3. update the TryFrom impl for List and Vector so the user can recover their data if they use these methods and they fail
  4. add Default impls that use the TryFrom impl

- remove problematic `FromIterator` impl
- return data if `TryFrom` fails to not drop data
@ralexstokes ralexstokes merged commit 5946af4 into main Jan 30, 2023
@ralexstokes ralexstokes deleted the fix-std-errors branch January 30, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant