Note possible checked_sub cases #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeddes
reviewed
May 23, 2023
ralexstokes
reviewed
Jun 5, 2023
I think we are fine to just add comments like you have done; I would consider calling them out explicitly with a |
ralexstokes
reviewed
Jun 5, 2023
ralexstokes
reviewed
Jun 5, 2023
ralexstokes
reviewed
Jun 5, 2023
ralexstokes
reviewed
Jun 5, 2023
Merged
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
===========================================
+ Coverage 44.28% 75.26% +30.97%
===========================================
Files 20 18 -2
Lines 1409 857 -552
===========================================
+ Hits 624 645 +21
+ Misses 785 212 -573
☔ View full report in Codecov by Sentry. |
ralexstokes
reviewed
Jun 8, 2023
ralexstokes
reviewed
Jun 8, 2023
ralexstokes
reviewed
Jun 8, 2023
This was referenced Jun 8, 2023
ralexstokes
reviewed
Jun 9, 2023
ralexstokes
reviewed
Jun 9, 2023
ralexstokes
reviewed
Jun 9, 2023
ralexstokes
reviewed
Jun 9, 2023
ssz-rs/src/merkleization/mod.rs
Outdated
Comment on lines
323
to
327
| for i in chunks.len()..leaf_count { | ||
| let start = leaf_start + (i * BYTES_PER_CHUNK); | ||
| let end = leaf_start + (i + 1) * BYTES_PER_CHUNK; | ||
| buffer[start..end].copy_from_slice(&zero_chunk); | ||
| } |
There was a problem hiding this comment.
I don't think the bounds on this iterator are correct chunks.len()..leaf_count and it was fine only bc we are just writing zeros to memory that was already zero (initialized in buffer)
I deleted it anyway bc it didn't seem to be doing anything
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #22, I've looked through the places we've used subtraction and haven't found any cases where
checked_subis strictly necessary. The constraints for each case are documented in comments before the subtraction. I've also added a few constraints where necessary.Opening as a draft since I'm not sure whether we want to use checked_sub anyway, just in case the constraints change and we miss something. There is a small performance cost to checked_sub and I'm fairly certain it's unnecessary, so it's down to a cautiousness vs performance tradeoff.