Add support for Scala.js and Scala Native #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
add-scalajs-native-support
branch
from
ede0da4 to
6a4c8cf
Compare
mdedetrich
changed the title
mdedetrich
force-pushed
the
add-scalajs-native-support
branch
2 times, most recently
from
050ae48 to
3a9d7de
Compare
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 75.53% 75.53%
=======================================
Files 28 28
Lines 282 282
Branches 13 12 -1
=======================================
Hits 213 213
Misses 69 69 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mdedetrich
force-pushed
the
add-scalajs-native-support
branch
3 times, most recently
from
d8504de to
794872a
Compare
|
@mdedetrich I think we will need to update this to support 1.16 as well |
mdedetrich
force-pushed
the
add-scalajs-native-support
branch
from
794872a to
b9403b9
Compare
mdedetrich
changed the title
|
@jeffmay I have just rebased the PR to pull in the latest changes from |
jeffmay
force-pushed
the
add-scalajs-native-support
branch
from
b9403b9 to
295cdf1
Compare
mdedetrich
force-pushed
the
add-scalajs-native-support
branch
from
295cdf1 to
523c056
Compare
mdedetrich
force-pushed
the
add-scalajs-native-support
branch
from
523c056 to
05bc5c5
Compare
|
Just rebased PR off main to pull in new github actions |
jeffmay
approved these changes
Oct 6, 2022
russellremple
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ScalaCheck 1.15.4 supports all of the latest stable versions of Scala.js/scala-native (see https://mvnrepository.com/artifact/org.scalacheck/scalacheck) I tried to add support for Scala.js/Scala.native.
Not entirely sure how the publishing works however both
compileandtestindicate that they are generatingtargetfor JS/native so publishing should theoritically work.Note that
.jsPlatform/.nativePlatformwork the same as.crossRow(see https://github.com/sbt/sbt-projectmatrix#scalajs-support for more info). On the same note,VirtualAxis.jsandVirtualAxis.nativeis not needed in theaxisValues =respectively because.jsPlatform/.nativePlatformautomatically adds this axis for you.