Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Right to Left (RTL) language support to Squeezeplay.
Previously, RTL languages like Hebrew were displayed backwards.
It would be like reading
xof nworb kciuq ehT
instead ofThe quick brown fox
.Now, an in-memory RTL string like:
ABC (DEF) GH (1234)
is displayed in a manner that makes visual sense to a native speaker:
(1234) HG (FED) CBA
The hebrewflip() function in LMS on the server side is designed for its display codepath (Fonts.pm and Graphics.pm), therefore we must flip the item_loop status messages locally using the FriBidi library. The two windows affected are Now Playing and Current Playlist.
Test cases:
(or individual cities like: → Tel Aviv-Yafo → All Stations). Example stations include:
Tested on macOS only:
The topmost makefiles for other platforms will need to have fribidi added.
Notes