Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more certificate revisions? #17

Closed
MrCrumbs opened this issue Oct 11, 2020 · 1 comment
Closed

Support more certificate revisions? #17

MrCrumbs opened this issue Oct 11, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@MrCrumbs
Copy link

I have a McAfee installer sample which Windows verifies correctly, while with Signify I get:

SignedPEParseError('Unknown certificate revision 3d6e',)

Any plans to support other revisions as well?
mcafee_sample.zip
@ralphje ralphje added the bug Something isn't working label Oct 11, 2020
ralphje added a commit that referenced this issue Jun 8, 2024
@ralphje
Do not try to read more than file length, refs #17
b7a579b
@ralphje
Copy link
Owner

ralphje commented Jun 8, 2024

Seems that this binary has some random XML in its certificate table, resulting in this error:

Screenshot 2024-06-08 190809

I have at least fixed a bug with trying to read too many bytes resulting in a MemoryError, but I'm not really sure how to proceed. You could simply read the first SignerInfo and that should work fine.

@MrCrumbs MrCrumbs closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2024
ralphje added a commit that referenced this issue Jun 8, 2024
@ralphje
Do not try to read more than file length, refs #17
81a135c
ralphje added a commit that referenced this issue Jun 9, 2024
@ralphje
Add option to swallow parse errors during verification, fixes #17
0ac68a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralphje @MrCrumbs