Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator refresh should be successful before syncing PINs #250

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

raman325
Copy link
Owner

@raman325 raman325 commented Jun 16, 2024

Proposed change

We shouldn't even try to decide whether to set or clear a code on a lock until we know we have accurate data from it.

Fixes #247 and fixes #225

Might be related:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@github-actions github-actions bot added bug Something isn't working python Pull requests that update Python code labels Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.29%. Comparing base (d0a3c97) to head (46455c5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   90.23%   90.29%   +0.06%     
==========================================
  Files          20       20              
  Lines        1239     1247       +8     
==========================================
+ Hits         1118     1126       +8     
  Misses        121      121              
Files Coverage Δ
...stom_components/lock_code_manager/binary_sensor.py 95.00% <80.00%> (+0.79%) ⬆️
custom_components/lock_code_manager/__init__.py 96.61% <81.81%> (-0.40%) ⬇️

@raman325 raman325 merged commit e49fd40 into main Jun 16, 2024
7 of 8 checks passed
@raman325 raman325 deleted the coordinator branch June 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
1 participant