Update to match node version for better type-safety #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macil
added a commit
to Macil/deno-advent2021
that referenced
this pull request
May 29, 2022
The argument types of memoizy-wrapped functions needs to be explicitly set until ramiel/deno-memoizy#1 goes through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the implementation to match the current implementation of the Node version of the project, which has better handling of types: the wrapped function's argument types are now preserved. This PR copies over the files exactly from the Node version besides the import line and a dropped eslint comment from the top.
This does change the main functions in mod.ts and fp.ts to become regular named exports instead of default exports. It is a breaking change but I think the consistency is good.
This PR also copies over the redis example in the readme and ports it over for Deno.