-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubles with the use of dygraphs #356
Comments
I've bisected this to c998fae |
ramnathv#356. The problem with evaluating without parentheses first is that named function declarations are valid expressions that return undefined (whereas evaluating with parentheses returns the function, as expected). It's true there may be weird corner-cases where switching this order leads to something else that's undesirable, but we've been operating with the 'with parentheses' model for so long that switching the ordering now will minimize backward-compatibility issues
Here's a potential fix for this issue |
#356. (#357) The problem with evaluating without parentheses first is that named function declarations are valid expressions that return undefined (whereas evaluating with parentheses returns the function, as expected). It's true there may be weird corner-cases where switching this order leads to something else that's undesirable, but we've been operating with the 'with parentheses' model for so long that switching the ordering now will minimize backward-compatibility issues
Thank you very much for your responsiveness! |
Do you think you will soon be submitting the latest version of htmlwidgets on the CRAN? |
Thanks for all the work on this, but it seems rstudio/dygraphs#237 is still not working even after the fix. I'll dig a little when I have some time. |
* upstream/master: Bump dev version Export JSEvals (ramnathv#381) Add missing roxygenize step (ramnathv#370) Add reportTheme arg to shinyWidgetOutput() (ramnathv#361) Try evaluating code with parentheses before without parentheses, closes ramnathv#356. (ramnathv#357) Bump version for development v1.5.1 release candidate (ramnathv#353) Add a comment; abstract out duplication in logic (ramnathv#354) Prevent staticRender from being called unconditionally when htmlwidgets.js is loaded after page load Bump version; update NEWS Use to schedule staticRender() iff jQuery 3 or higher is present in shinyMode Bump version Bump version for release
With htmlwidgets 1.5.1, there are some big troubles with some functions of the dygraphs package (e.g. dyStackedBarGroup or dyShadow).
Its is OK with the version 1.3.
I don't know if you should fix htmlwidgets or @pshevtsov should adapt dygraphs to version 1.5.1.
The text was updated successfully, but these errors were encountered: