feat(highlights): neotest

[windowsrefund]

Disclaimer: I have no clue what I'm doing and just pulled bits in from other support files.

Looks decent but I don't know how to remedy the "chicken/egg" scenario involving the background color of signcolumn vs. the background color of the neotest window.

[windowsrefund]

I refactored this around what I found in this theme and ended up removing the dark SignColumn in order to get past the previously mentioned inconsistency. I hope you'll consider the change. This also has a nice side-effect of the first indentation line looking nicer since it isn't "mashed up against" the once-darker column.

[ramojus]

Hey, sorry for the delay, this looks great, but I have some ideas on how it could be improved. I will look into it sometime at the end of the month, as I will have much more free time by then.

[antoineco]

I saw this PR right after posting #30. Sorry for the duplicate!

Maybe it would be a good idea to pick ideas from both implementations? For example, the colored NeotestFile and NeotestDir are quite nice IMO, and we can make use of the ui_green, ui_red, etc. colors for signs (without an explicit background, preferably).

---

before

after

[ramojus]

I think we should leave this file unchanged. Default neovim setups have signcolumn to the left of numbercolumn, so this change will make it look inconsistent when signcolumn is between file-tree and numbercolumn, both of which have darker backgrounds.

[ramojus]

Hey @windowsrefund @antoineco, this is what I've arrived at after considering your suggestions:

    local config = require('mellifluous.config').config

    hl.set('NeotestAdapterName', { fg = colors.fg3 })
    hl.set('NeotestFocused', { fg = colors.fg, style = { bold = true } })
    hl.set('NeotestTarget', { style = { underline = true } })
    hl.set('NeotestIndent', { fg = colors.fg4 })
    hl.set('NeotestExpandMarker', { link = 'NeotestIndent' })

    hl.set('NeotestDir', { fg = hl.get('Directory').fg })
    hl.set('NeotestFile', { fg = colors.fg2 })
    hl.set('NeotestNamespace', { link = '@namespace' })

    hl.set('NeotestTest', { fg = colors.fg })
    hl.set('NeotestRunning', { fg = hl.get('Function').fg })
    hl.set('NeotestPassed', { link = '@markup.list.checked' })
    hl.set('NeotestFailed', { fg = colors.ui_red })
    hl.set('NeotestSkipped', { fg = colors.fg })
    hl.set('NeotestUnknown', { fg = colors.fg })
    hl.set('NeotestMarked', { bg = (config.is_bg_dark and colors.bg5) or colors.bg4 })

I'm not a neotest user, so please tell me if something could be better.

I like function for NeotestRunning, as it indicates action. NeotestSkipped and NeotestUnknown have normal fg, because I don't think they are important. NeotestMarked could be anything (e.g. folder, namespaceq), so I decided to not touch the fg for this one and instead made it seem almost like it's visually selected.
I'm not sure if there can be more than one NeotestAdapter for one project, so I made it a bit hidden (like root folder for file-tree). If there can be, we should probably link it to Title.

I have no idea what NeotestWinSelect is for, so please tell me if you know.

Edit: On second thought, we should only take the fg of Function for NeotestRunning (not link to it), as it wouldn't make sense to apply any possible style that Function could have to an icon. Updated the snippet.

[antoineco]

I'm happy with those suggestions 👍
I have never encountered NeotestWinSelect either.

[windowsrefund]

@ramojus Thank you for the help. Everything looks great but the background color in the signcolumn is not cohesive. That's what got me wanting to move away from the darker color. Here's where I'm at now after incorporating your update:

It just seems to me like the darker signcolumn isn't exactly adding any real value while adding 2 problems:

1. This scenario where the background color of a thing would need to be different from the corresponding background color of the same thing shown elsewhere.
2. The first horizontal indent line (I think that's the indent-blankline plugin) doesn't quite stand out and is somewhat mashed up against it

If you'd prefer to settle on this, I can surely look into treating the signcolumn color as a personal preference and try to figure out how to override it.

Thanks again

[antoineco]

Just one addition: the non-homogeneous background color of Neotest signs in signs columns with darker background is a known issue:

• [BUG] Background of icon in statuscolumn does does not match the statuscolumn background nvim-neotest/neotest#220

IMO the colorscheme should ignore this and we should seek for a resolution upstream.

---

@windowsrefund you can set this value to true in your config if you prefer the number/signs/fold column to have the same background as the rest of the window:

mellifluous.nvim/doc/mellifluous.txt

Lines 87 to 88 in 454cb9f

	flat_background = {
	line_numbers = false,

[windowsrefund]

@antoineco Thanks for pointing out the upstream issue. Couldn't agree more.

As for the flat_background options, I finally understand. That said, setting line_numbers = true makes it pretty much an all or nothing thing and not what I displayed above in the 2nd screen shot. That said, I think I'll break that concern out into a feature request at some point. This PR should be good to go.

Thanks everyone for all the help.

[ramojus]

Oh, I did not notice this issue before. @windowsrefund if you just want to customize SignColumn, you can also use this config:

highlight_overrides = {
    dark = function(hl, colors)
        hl.set('SignColumn', { bg = colors.bg })
    end,
}

This will get applied after all of the other highlights though, so GitSigns will now look out of place. Feel free to open an issue for this, there should probably be a better solution.

[windowsrefund]

@ramojus Thank you for that tip. I had actually tried to configure that at some point but obviously failed. BTW, I just noticed both tender and kanagawa_dragon are not impacted by the gitsigns issue so I'm now happily using this with the latter. Looks great!