feat(highlights): add mason support #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Looking forward to seeing this merged. By the way, no need to update doc/mellifluous.txt as I learned it is automatically updated. |
|
@windowsrefund thanks for the hint! |
|
@antoineco Thank you for all these PRs. Exciting! |
|
Everything is great otherwise, thanks! Sorry for the delay on this one, Mason UI was not working in my setup for some reason. |
|
@ramojus No problem!
The "otherwise" makes me guess that you had a change in mind, but possibly didn't submit the review comment? |
ramojus
reviewed
May 31, 2024
|
Here is an updated screenshot after addressing the suggestions from the review: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the highlighting of Mason windows (a popular installer for external tools such as LSP servers), which is inconsistent with the colorscheme by default.
before
after
Outdated screenshots