Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(highlights): colored underlined LSP diagnostics #36

Merged
merged 1 commit into from
May 25, 2024
Merged

feat(highlights): colored underlined LSP diagnostics #36

merged 1 commit into from
May 25, 2024

Conversation

antoineco
Copy link
Contributor

By default, Neovim uses a color to underline LSP diagnostics. The color matches the severity of the diagnostic, and is very useful to be able to quickly identify multiple diagnostic severities appearing on the same line:

image

The colorscheme currently doesn't color underlined LSP diagnostics. The example below isn't particularly realistic, but I encountered the case multiple times in Go and Rust codebases, and had to jump to each diagnostic individually (or call vim.diagnostic.open_float()) to be able to identify their severity:

Screenshot 2024-05-25 091624

After the changes from this PR, colored underlines are restored:

Screenshot 2024-05-25 091536

@ramojus
Copy link
Owner

ramojus commented May 25, 2024

This is amazing, I was not aware that it's possible. Thanks!

@ramojus ramojus merged commit 48e89d7 into ramojus:main May 25, 2024
@antoineco antoineco deleted the feat/lsp-colored-underline branch May 25, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants