Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link icon in text editor, Make external link open in new tab #406

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Sep 26, 2024

Related Item(s)

#384

Changes

  • Updated the link icon for the "Insert Link" dropdown of the text editor
  • Made hyperlinks created using "Add External Link (New Tab)" option of the dropdown open in a new tab

Notes

  • The text editor, vue-markdown-editor, seems to use unicode characters for its icons. Initially, the link icon was e6fe. I've now switched it to 1f517.
  • Before:
    image
  • After:
    image

Testing

Steps:

  1. Open an existing product (or create a new one)
  2. Create a new text slide
  3. Observe the new link icon
  4. Open the "Insert Link" dropdown and click the "Add External Link (New Tab)" option
  5. Enter https://www.google.com/ as the hyperlink
  6. Save the product and open the preview
  7. Scroll down to the last slide and click the link you created. It should open in a new tab.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-384-fix

@IshavSohal IshavSohal changed the title Update link icon in text editor Update link icon in text editor, Make external link open in new tab Sep 26, 2024
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

@yileifeng yileifeng merged commit 17398a4 into ramp4-pcar4:main Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants