-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate crates #199
Separate crates #199
Conversation
I think the best organization for our crates will be the following:
In this PR So right now, it's pretty much what #191 was proposing. |
This is now ready for review. Please @ramsayleung take a look at #166 after merging this; it's been open for a while and I would like to finish it before #173 if possible. I'm trying to clean up the CI while I'm at it and... can you remind me why are we cross-compiling at all? It's not like Rspotify implements anything different for any architecture, so if that failed it would actually be Rust's fault. We'd get rid of six currently unnecessary checks in the CI; I could remove Also, I've tried to use Edit: My theory is correct, if I remove |
Since
Sorry for this, I don't realize that it's ready to review, I will check it on the weekend :) |
I am not sure if this PR ready to merge, even though I have merged all separated PRs |
Yes, you can merge it. |
Finally, it takes so long, but we reached it :) |
Yes I can't believe it! We're getting closer to v0.11 :) |
Description
Some work towards #191. I've ended up separating the crates but leaving the auth, http and client ones mixed under
rspotify_client
until #173 is worked on.Motivation and Context
See #191
Dependencies
Should be the same
Type of change
Please delete options that are not relevant.
This change means that types like
FullAlbum
in the model now have to be public.How Has This Been Tested?
The previous tests still work now. Same goes for the examples (which by the way I had to fix because they weren't working)
Closes #191