Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make available_markets optional #286

Merged
merged 3 commits into from
Nov 20, 2021
Merged

Make available_markets optional #286

merged 3 commits into from
Nov 20, 2021

Conversation

hrkfdn
Copy link
Contributor

@hrkfdn hrkfdn commented Nov 20, 2021

Description

Fixes #285

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Test suite was extended

@marioortizmanero
Copy link
Collaborator

Could you please add these changes to the changelog? You might have to make a new entry, I forgot about that. We can release it for 0.11.3.

@hrkfdn
Copy link
Contributor Author

hrkfdn commented Nov 20, 2021

@marioortizmanero Like this?

@marioortizmanero
Copy link
Collaborator

Perfect, thanks a lot for the contribution! <3

@marioortizmanero marioortizmanero merged commit 65f66e6 into ramsayleung:master Nov 20, 2021
@hrkfdn hrkfdn deleted the hf/fix_album_optional_available_markets branch November 20, 2021 19:41
@hrkfdn
Copy link
Contributor Author

hrkfdn commented Nov 20, 2021

@marioortizmanero Sure :)! Do you have a rough estimate on when you'll release 0.11.3?

@marioortizmanero
Copy link
Collaborator

marioortizmanero commented Nov 20, 2021

I'd like to close #281. I'm still not fully sure about how to approach for rspotify-model, but we need it ASAP because otherwise most of the links in the docs are broken. Also merging all the pending PRs, but that should be pretty easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON parse error when fetching user albums with market set to FromToken
2 participants