Optional cursors #303
Merged
Optional cursors #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioortizmanero
force-pushed
the
opt-cursors
branch
from
d43195c to
fff7537
Compare
Merged
|
@ramsayleung we should probably release a new version after this PR, we already have a few changes waiting. |
ramsayleung
approved these changes
Mar 8, 2022
|
LGTM
Great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the
cursorsfield optional. It also fixes a couple new clippy warnings.Motivation and Context
See #301
Dependencies
None
Type of change
Please delete options that are not relevant.
How has this been tested?
See #301. Furthermore, all tests continue to pass.
Is this change properly documented?
Yes