Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webapp example #361

Merged
merged 16 commits into from
Dec 27, 2022
Merged

Update webapp example #361

merged 16 commits into from
Dec 27, 2022

Conversation

ramsayleung
Copy link
Owner

@ramsayleung ramsayleung commented Sep 20, 2022

Description

Features:

  • Add token refreshing
  • Use the new API properly (at some point we do spotify.token = ..., we can surely avoid that).
  • Proper error handling? It has too many unwrap in my opinion.
  • Add string interpolation where possible
  • Include it in the CI somehow so that this doesn't happen anymore.

Motivation and Context

#324

Dependencies

  • log
  • env_log
  • cookie

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Is this change properly documented?

Not yet.

@ramsayleung ramsayleung changed the title [WIP] Update webapp example Update webapp example Sep 29, 2022
@ramsayleung ramsayleung marked this pull request as ready for review September 29, 2022 15:29
@marioortizmanero marioortizmanero force-pushed the ramsay_fix_failed_example branch from 3ab9e4c to e220b09 Compare December 26, 2022 16:31
@marioortizmanero marioortizmanero mentioned this pull request Dec 26, 2022
1 task
@marioortizmanero
Copy link
Collaborator

Thanks for the contribution and sorry for the late PR! Can confirm that this works wonderfully and fixes #324. We should first merge #374 so that CI passes all the checks.

@marioortizmanero marioortizmanero force-pushed the ramsay_fix_failed_example branch from e220b09 to e9f5f8c Compare December 27, 2022 13:02
@marioortizmanero marioortizmanero merged commit 48b74b4 into master Dec 27, 2022
@marioortizmanero marioortizmanero deleted the ramsay_fix_failed_example branch December 27, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants