Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing optional market field to some APIs #432

Merged
merged 6 commits into from
Jul 15, 2023

Conversation

aome510
Copy link
Contributor

@aome510 aome510 commented Jul 15, 2023

Description

Resolves #423

  • added missing optional market field to following APIs:
    • track
    • album
    • albums
    • album_track
    • album_track_manual
  • made market field in artist_top_tracks API optional instead of required

Context

Required for aome510/spotify-player#207

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@aome510
Copy link
Contributor Author

aome510 commented Jul 15, 2023

@ramsayleung can you approve to run the PR workflow?

@ramsayleung ramsayleung merged commit 2907e2f into ramsayleung:master Jul 15, 2023
@ramsayleung
Copy link
Owner

Thanks for your contribution :)

@aome510
Copy link
Contributor Author

aome510 commented Jul 15, 2023

Thanks for being patient lol. Idk why the clippy thing doesn't work with examples folder for me.

@ramsayleung
Copy link
Owner

How did you run the clippy command in your local development environment?

@aome510
Copy link
Contributor Author

aome510 commented Jul 15, 2023

I used the same command as in the action

@aome510
Copy link
Contributor Author

aome510 commented Aug 26, 2023

hi @ramsayleung do you know when the new version is released? I want to fix some issues in https://github.com/aome510/spotify-player and need this patch.

@ramsayleung
Copy link
Owner

ramsayleung commented Aug 26, 2023

I could release a new version for this patch, since no more features are pending that need to include in this release.

#436

PS: The new version v0.12.0 is released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing market field on the album API call
2 participants