Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn a local Tcplistener to handle the callback url #513

Merged
merged 9 commits into from
Jan 1, 2025

Conversation

ramsayleung
Copy link
Owner

@ramsayleung ramsayleung commented Dec 30, 2024

Description

  • Spawn a local TCPListener to handle callback url rather manually copy/paste into terminal for better deverloper experience.
  • Mark artist_related_artists, track_features, tracks_features as deprecated because Spotify has deprecated these endpoints and delete related tests as Spotify will return 403 to these deprecated endpoints.

Acknowledge:

This solution of TCPListener is highly inspired by librespot.

Motivation and Context

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • unit test: get_socket_address_none, get_socket_address_localhost
  • run me example with redirect url: http://127.0.0.1: 8000/callback, open in the webbrowser and automatically connect to local TCPListener, work without human interaction.

image
image

Is this change properly documented?

Yes.

@ramsayleung ramsayleung merged commit 533c071 into master Jan 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant