Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent type error while converting invalid value type in convertToDatabaseValue() #170

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Nov 22, 2021

Description

We cannot call method_exists() with anything else than string|object

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@simPod simPod requested a review from ramsey as a code owner November 22, 2021 16:51
@simPod simPod changed the title Prevent type error while converting invalid value type in `convertToDatabaseValue() Prevent type error while converting invalid value type in convertToDatabaseValue() Nov 22, 2021
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #170 (c10eb51) into main (135fadb) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c10eb51 differs from pull request most recent head 79a9147. Consider uploading reports for the commit 79a9147 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##                main      #170   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        57        60    +3     
===========================================
  Files              5         5           
  Lines            110       110           
===========================================
  Hits             110       110           
Impacted Files Coverage Δ
src/UuidBinaryOrderedTimeType.php 100.00% <100.00%> (ø)
src/UuidBinaryType.php 100.00% <100.00%> (ø)
src/UuidType.php 100.00% <100.00%> (ø)

@ramsey
Copy link
Owner

ramsey commented Nov 22, 2021

PHP 5.4 and 5.5 don't like use function. 😄

…atabaseValue()`

We cannot call `method_exists()` with anything else than `string|object`
@simPod
Copy link
Contributor Author

simPod commented Nov 23, 2021

@ramsey I see, removed

@simPod simPod marked this pull request as draft November 29, 2021 22:00
@simPod simPod marked this pull request as ready for review November 29, 2021 22:00
@ramsey
Copy link
Owner

ramsey commented Jan 5, 2022

Thank you for contributing! 🎉

@ramsey ramsey merged commit 7396241 into ramsey:main Jan 5, 2022
@simPod simPod deleted the type-error branch January 5, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants