Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds description on how to configure roave/psr-container-doctrine #185

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Adds description on how to configure roave/psr-container-doctrine #185

merged 1 commit into from
Nov 3, 2022

Conversation

arueckauer
Copy link
Contributor

Description

This PR provides an example on how to use it with roave/psr-container-doctrine.

Motivation and context

Laminas users will most likely utilize roave/psr-container-doctrine to integrate doctrine in their projects. The existing Zend Framework configuration is not compatible with it. The added description uses the psr-container-doctrine full-config example.

How has this been tested?

Locally tested. Since it describes the configuration of a third-party library, no tests were added. This change does not affect existing features or behavior.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@arueckauer arueckauer requested a review from ramsey as a code owner September 5, 2022 06:40
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #185 (d092d60) into main (af426c2) will not change coverage.
The diff coverage is n/a.

❗ Current head d092d60 differs from pull request most recent head 528d941. Consider uploading reports for the commit 528d941 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #185   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        60        60           
===========================================
  Files              5         5           
  Lines            106       106           
===========================================
  Hits             106       106           

README.md Show resolved Hide resolved
@ramsey ramsey merged commit cc6cdc4 into ramsey:main Nov 3, 2022
@arueckauer arueckauer deleted the feature/configuration-in-roave/psr-container-doctrine branch November 4, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants