-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UUID version 7 generator #191
Conversation
a52a6ea
to
c703fdc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 60 61 +1
===========================================
Files 5 6 +1
Lines 105 107 +2
===========================================
+ Hits 105 107 +2
|
c703fdc
to
2bd21fe
Compare
@ramsey tests fail on PHP below 8.0. |
Good question. I see two options:
The second option seems like it might be the best to avoid dropping support for < PHP 8.0 at the moment. |
2bd21fe
to
354fa62
Compare
354fa62
to
9498c0d
Compare
@ramsey updated PR, I hope skipped tests are allowed in workflow. I had to go for full class name instead of |
Thank you for contributing! 🎉 I committed this in 4b56c72 |
Description
added a UUID Version 7 Generator
Motivation and context
with the introduction of new UUID Types, there is a better way then
Percona's solution
to achieve the sortable, time-based UUIDs that can be efficiently used as primary keys.Types of changes
PR checklist