Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctrine/dbal v4 #242

Closed
wants to merge 2 commits into from
Closed

Allow doctrine/dbal v4 #242

wants to merge 2 commits into from

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Feb 5, 2024

Description

Allow doctrine/dbal v4

Motivation and context

https://github.com/doctrine/dbal/releases/tag/4.0.0

How has this been tested?

Not yet, CI?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@ruudk ruudk requested a review from ramsey as a code owner February 5, 2024 08:01
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee0b1ef) 99.27% compared to head (f76168e) 99.27%.
Report is 1 commits behind head on main.

❗ Current head f76168e differs from pull request most recent head ddffc49. Consider uploading reports for the commit ddffc49 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #242   +/-   ##
=========================================
  Coverage     99.27%   99.27%           
  Complexity       68       68           
=========================================
  Files             6        6           
  Lines           138      138           
=========================================
  Hits            137      137           
  Misses            1        1           

@Chris53897
Copy link

@ruudk Thanks for working on this.
Can you please change this line to "doctrine/orm": "^2.5 || ^3.0", to allow the install of dbal 4 ?

"doctrine/orm": "^2.5",

There is some work todo, to make it work with dbal 4.

@ruudk
Copy link
Contributor Author

ruudk commented Feb 6, 2024

Done

@Chris53897
Copy link

It was hard to pass all git hooks prechecks.
I did a seperate PR i try to fix some issues.
#245

@Chris53897
Copy link

I did closed my PR in favor of #247
I think this PR should be closed too

@ruudk ruudk closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants