Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ParameterType::BINARY to UuidBinaryOrderedTimeType #72

Closed
wants to merge 7 commits into from

Conversation

ksowa
Copy link
Contributor

@ksowa ksowa commented Feb 28, 2019

By adding this method, we allow Doctrine to set appropriate type for binding UUID parameters in queries. Otherwise they are bound as ParameterType::STRING by default. The default approach works in MySQL, but does not in Sqlite, when e.g. running functional tests.

@devcube-pl
Copy link

It should be added in UuidBinaryType class too

@ramsey ramsey self-requested a review as a code owner October 26, 2021 15:28
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #72 (7ca73fd) into main (cc6cdc4) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #72   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        60        61    +1     
===========================================
  Files              5         5           
  Lines            105       107    +2     
===========================================
+ Hits             105       107    +2     
Impacted Files Coverage Δ
src/UuidBinaryOrderedTimeType.php 100.00% <100.00%> (ø)

@@ -12,6 +12,7 @@

namespace Ramsey\Uuid\Doctrine;

use Doctrine\DBAL\ParameterType;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fine to have this patch, but then we need to bump the minimum supported doctrine/dbal to ^3.

ksowa and others added 4 commits March 25, 2022 22:43
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…eckout-3

Bump actions/checkout from 2 to 3
@ramsey
Copy link
Owner

ramsey commented Dec 20, 2022

Thank you for contributing! 🎉

Apologies on the lengthy delay. I've committed this change in 41cfa5f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants