added helper method for COMB UUIDs #180
Conversation
|
At first glance, the approach looks good to me. I can take a more detailed look later this week and offer some pointers on testing. Thanks! |
| { | ||
| $currentCodec = $this->getCodec(); | ||
| $combGenerator = new CombGenerator($this->getRandomGenerator(), $this->getNumberConverter()); | ||
| $combCodec = new TimestampFirstCombCodec($this->getUuidBuilder()); |
There was a problem hiding this comment.
There's a difference between a COMB UUID and a Timestamp First COMB UUID. I'm worried that that name of the method comb() causes confusion, since you're using the TimestampFirstCombCodec() internally.
There was a problem hiding this comment.
Indeed but TimestampFirstCombCodec is the one that produces monotonically increasing UUIDs, which is the whole point.
Do you have an alternative name in mind?
|
Any other thoughts on choosing a different name? I still disagree with using |
|
It's ok with me. It appears that I managed to nuke my fork though, sorry. I'll resubmit the PR (with the name of the helper set to |
This PR add a helper method to the
Uuidclass for generating sequential COMB UUIDs, as discussed on issue #53.Disclaimer: this proposal is a WIP. Though the feature seems to work as intended I've decided to open the PR early on to get feedback on the approach (feels a bit clunky to me). I'd also like input on how to approach testing such feature.