Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): update macos version used by github action #20

Merged

Conversation

ryancurrah
Copy link
Contributor

MacOS Catalina is no longer supported by Apple or GitHub https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22. This PR updates the runner used for MacOS to Big Sur.

Issue: #19

@ryancurrah ryancurrah force-pushed the update-to-supported-macos-version branch from 3c13127 to 71ebc3d Compare December 20, 2022 16:19
@mook-as mook-as self-requested a review December 20, 2022 19:11
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change itself looks fine, but I seem to be having issues actually running it due to homebrew conflicts. Run log.

Error installing Python 3

==> Pouring python@3.10--3.10.9.big_sur.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite python@3.10

To list all files that would be deleted:
  brew link --overwrite --dry-run python@3.10

Possible conflicting files are:
/usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/2to3
/usr/local/bin/idle3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/idle3
/usr/local/bin/pydoc3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/pydoc3
/usr/local/bin/python3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3
/usr/local/bin/python3-config -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3-config

At least, I think that's the relevant error?

@ryancurrah
Copy link
Contributor Author

The code change itself looks fine, but I seem to be having issues actually running it due to homebrew conflicts. Run log.

Error installing Python 3


==> Pouring python@3.10--3.10.9.big_sur.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite python@3.10

To list all files that would be deleted:
  brew link --overwrite --dry-run python@3.10

Possible conflicting files are:
/usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/2to3
/usr/local/bin/idle3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/idle3
/usr/local/bin/pydoc3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/pydoc3
/usr/local/bin/python3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3
/usr/local/bin/python3-config -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3-config

At least, I think that's the relevant error?

Hrm yeah, that is interesting. I will look into it.

@ryancurrah
Copy link
Contributor Author

ryancurrah commented Dec 21, 2022

Looks like this is a known recent issue actions/setup-python#577.

@ryancurrah
Copy link
Contributor Author

ryancurrah commented Dec 21, 2022

I was able to get it working by removing the pre-existing symlinks before running brew upgrade. See the successful action here https://github.com/ryancurrah/lima-and-qemu/actions/runs/3745534709/jobs/6360069189.

Should we wait and see if GitHub will fix this issue or go ahead with the rm fix and remove it once actions/setup-python#577 is resolved?

@ryancurrah ryancurrah force-pushed the update-to-supported-macos-version branch from dc3075a to 3190e99 Compare December 21, 2022 01:45
@mook-as
Copy link
Contributor

mook-as commented Dec 21, 2022

Oh, thanks for identifying the issue in the runner images! Given that it was filed yesterday and being actively worked on, it's probably best to just wait for them to resolve it first? I'll schedule a reminder for myself in a week (if we haven't merged this PR by then). If they haven't fixed it in a week, we could just merge in your workaround.

@ryancurrah
Copy link
Contributor Author

Oh, thanks for identifying the issue in the runner images! Given that it was filed yesterday and being actively worked on, it's probably best to just wait for them to resolve it first? I'll schedule a reminder for myself in a week (if we haven't merged this PR by then). If they haven't fixed it in a week, we could just merge in your workaround.

Sounds good to me.

@mook-as mook-as self-requested a review December 21, 2022 19:18
@ryancurrah
Copy link
Contributor Author

@mook-as looks like this is the best solution for now. Others seem to be following suit and doing some variant of this fix in their actions.

@ryancurrah
Copy link
Contributor Author

Im re-building this again and it is failing on a lot of new changes to the image. I'm fixing it now.

Signed-off-by: Ryan Currah <ryan@currah.ca>
@ryancurrah
Copy link
Contributor Author

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@jandubois jandubois dismissed mook-as’s stale review January 7, 2023 00:49

Request has been addressed

@jandubois jandubois merged commit 145c672 into rancher-sandbox:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants