-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions are not being installed with deployment profiles and allowed images list #4920
Comments
yes,i have the same problem, i guess the reason is that the timeout 230 seconds is the load balance of azure app, my network speed just at 500~600 kb/s, i retry many times, every there was more than 40m left can't be downloaded. |
Issue happens with both dockerd and containerd. Both system and user deployment profiles |
That sounds like Docker Hub doesn't like us. If you're doing this remotely (using Remote Desktop or something to a machine in the lab), perhaps there's been too many requests from that IP address and you're being rate limited? That should be HTTP 429 instead, though… |
Oh, it's the image allow list; the system locked profile has: <key>containerEngine</key>
<dict>
<key>allowedImages</key>
<dict>
<key>enabled</key>
<true/>
<key>patterns</key>
<array>
<string>nginx</string>
<string>busybox</string>
</array>
</dict>
</dict> That doesn't cover |
I'm using my own machine. |
But if we have it allowed in the extensions list shouldn't this suffice? the image needs to be in both images and extensions list? |
Correct, it needs to show up in both lists. We could consider a new enhancement issue (but then it gets confusing for the admins going the other way too). |
Yes, Rancher Desktop is supposed to add all allowed extensions to the Allowed Images list internally (not included in I don't know if this got implemented or not; @mook-as do you remember? |
@jandubois I don't recall that requirement at all… |
So, what is the purpose of the allowed extensions list? Should this be used then just to specify tags but list the image ID in the allowed images list? It's now a bit unclear on what should be the expected behaviour when we have both lists enabled. |
I thought it was in the original story, but I can't find it right now either. I did talk about it in #4655 (comment) Anyways, I'll create an issue for it, and then we can discuss if there are reasons not to do this. |
The purpose of the list is that an administrator can explicitly allow specific extensions to be loaded. This can be more narrow than the general Allowed Images list:
Extensions are more closely restricted because they can execute code on the host. Regular images only run inside the container runtime inside the VM.
The Allowed Images list will restrict which images can be pulled from a registry. Since extensions need to be pulled, they will need to be allowed (but can't limit to a specific tag). Even if the extension image can be pulled, it still needs to be included in the Allowed Extensions list (including tag, if specified). Otherwise the extension will not be enabled, even though it may have been pulled already. I've created #4926 to add all allowed extensions to the Allowed Images list automatically. It doesn't make sense to allow an extension if you don't intend to allow the user to pull the corresponding image. So there is no need to require the admin to add it to both lists. Note that you can lock down the extension list without having the Allowed Images list enabled. |
Ok. So, in case we have the image in the allowed images list, but not in the allowed extensions, user will just be able to run them with the container runtime in the VM. But not to instal an extension from that image, correct? |
That is correct. |
We'll look at this more for 1.10. @jandubois to put something in release notes for 1.9 |
I saw one problem: After making that change, when When |
I had closed this, but reopened due to Gary's comment at #4920 (comment) -- but I would mark this closed because I can now run and install the allowed extensions as long as I turn off the allowed-images field. |
Actual Behavior
I am not sure if the deployment profiles and the allowed images list are somehow breaking lima, but none of the extensions regardless if they are allowed or not in the deployment profiles, are failing to download
Error says :
limactl exited with code 1
Steps to Reproduce
Result
All the extensions are failing to download
Important information from the logs:
extensions.log
:from
lima.log
:From
serial.log
:Archive.zip
lima-logs.zip
Expected Behavior
Extensions that belong to the allowed images list or the allowed extensions list should be installed with no errors. Extensions that are not in any of these list should be preventing from installing with a bad request error.
Additional Information
Here are the files containing each of the deployment profiles used
System locked profile - profile.txt
System default profile - sys-profile-default.txt
User locked profile - user-profile-locked.txt
User default profile -
user-profile-defaults.txt
Rancher Desktop Version
1.7.0-1669-g22e4b6c2
Rancher Desktop K8s Version
1.26.2
Which container engine are you using?
containerd (nerdctl)
What operating system are you using?
macOS
Operating System / Build Version
macOS Monterey
What CPU architecture are you using?
x64
Linux only: what package format did you use to install Rancher Desktop?
None
Windows User Only
No response
The text was updated successfully, but these errors were encountered: