Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSL-Helper: Certs: Make a copy of foreign memory #6308

Merged
merged 2 commits into from
Jan 11, 2024
Merged

WSL-Helper: Certs: Make a copy of foreign memory #6308

merged 2 commits into from
Jan 11, 2024

Commits on Jan 11, 2024

  1. WSL-Helper: Certs: Make a copy of foreign memory 

    We enumerate system certificates on Windows asynchronously and return the
results (as *x509.Certificate objects) in a channel.  It turns out that
those certificates can refer to memory passed in via ParseCertificate(),
so we ended up using a certificate that referred to freed memory.  Avoid
the issue by explicitly making a copy of that slice.

Signed-off-by: Mark Yen <mark.yen@suse.com>
    @mook-as
    mook-as committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b0f50ab View commit details
    Browse the repository at this point in the history

  2. WSL-Helper: Add test for cert use-after-free 

    Signed-off-by: Mark Yen <mark.yen@suse.com>
    @mook-as
    mook-as committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    765822c View commit details
    Browse the repository at this point in the history