WSL-Helper: Fix getting MSI version #6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the MSI version, we initially supply no buffer to get the total buffer size required. This can return success instead of ERROR_MORE_DATA as previously expected; the actual result is the same, and we need to allocate a buffer large enough. Signed-off-by: Mark Yen <mark.yen@suse.com> Fixes: b7aa9dd
jandubois
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the MSI version, we initially supply no buffer to get the total buffer size required. This can return success instead of
ERROR_MORE_DATAas previously expected; the actual result is the same, and we need to allocate a buffer large enough.