Fix fs.watch leak with a timestamp to prevent repetitive buildFromConfig #7238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Seese <seesemichaelj@gmail.com>
mook-as
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Thanks for the PR! I have some requests, but that doesn't mean the PR being completely rejected — I'm happy to be convinced otherwise.
If I understand your analysis in #6315 correctly, the watcher instances are in fact sticking around after the abort controller has triggered?
We may need to manually call close() on the watchers instead of relying on the abort signal?
Signed-off-by: Mike Seese <seesemichaelj@gmail.com>
mook-as
requested changes
Jul 24, 2024
Signed-off-by: Mike Seese <seesemichaelj@gmail.com>
mook-as
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6315 by preventing
Tray::watchForChangesfrom calling in a cyclic behavior in the first place. The prior logic was was designed to preventTray::buildFromConfigfrom being called too frequently. The new logic callsTray::buildFromConfigon each file change but the function will only continue if a second has passed since it was successfully called last time. With this,Tray::watchForChangesis only called once.CC @mook-as