Remove vtunnel guest agent #7371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nino-K
force-pushed
the
remove-vtunnel-guest-agent
branch
2 times, most recently
from
8a2d0c1
to
46b0e9d
Compare
mook-as
requested changes
Aug 21, 2024
src/go/guestagent/README.md
Outdated
| In newer versions of Kubernetes†, `kubelet` no longer creates a listener for NodePort services. We therefore need to create those listeners manually, so that port forward works correctly as in the container port forwarding above. | ||
|
|
||
| † 1.21.12+, 1.22.10+, 1.23.7+, 1.24+ | ||
| [Rancher Desktop Guest Agent](https://github.com/rancher-sandbox/rancher-desktop/blob/e224943683920a7ecb9ca5655097075a9ce4cefe/docs/networking/windows/rancher-desktop-guest-agent.md) |
There was a problem hiding this comment.
Probably better to make this a relative link
Suggested change
| [Rancher Desktop Guest Agent](https://github.com/rancher-sandbox/rancher-desktop/blob/e224943683920a7ecb9ca5655097075a9ce4cefe/docs/networking/windows/rancher-desktop-guest-agent.md) | |
| [Rancher Desktop Guest Agent](/docs/networking/windows/rancher-desktop-guest-agent.md) |
| @@ -220,7 +187,7 @@ func main() { | |||
| // of the legacy network, requiring listeners only. In listenerOnlyMode, we create | |||
There was a problem hiding this comment.
Line 185 of the comment still refers to privileged services.
It sounds like we never want listenerOnlyMode at all (since the comment says it should only be active in old network). Presumably we'll deal with that later in a separate PR?
There was a problem hiding this comment.
Yeah, I will make a follow-up PR to remove this one.
Nino-K
force-pushed
the
remove-vtunnel-guest-agent
branch
from
46b0e9d
to
90bcd5a
Compare
mook-as
approved these changes
Aug 21, 2024
All vtunnel refrences is removed out of the code, the guest agent now only supports the namespaced network. Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Nino-K
force-pushed
the
remove-vtunnel-guest-agent
branch
from
90bcd5a
to
ece9feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all the vtunnel and privileged services references out of the guest agent.
Fixes: #7362