Fixes the startup arguments for guestAgent #7372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nino-K
force-pushed
the
fix-guest-agent-start
branch
from
5972654
to
6c2a201
Compare
mook-as
requested changes
Aug 21, 2024
pkg/rancher-desktop/backend/wsl.ts
Outdated
| const rdNetworking = !!config?.experimental.virtualMachine.networkingTunnel; | ||
|
|
||
| this.privilegedServiceEnabled = rdNetworking ? false : await this.invokePrivilegedService('start'); | ||
| // const rdNetworking = !!config?.experimental.virtualMachine.networkingTunnel; |
There was a problem hiding this comment.
Shouldn't this line just be removed?
GuestAgent no longer supports/needs a flag for privileged services. Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Nino-K
force-pushed
the
fix-guest-agent-start
branch
from
6c2a201
to
c4ebb1e
Compare
mook-as
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GuestAgent no longer supports/needs a flag for privileged services.
Fixes: #7362