Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine both wsl-init files #7396

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Combine both wsl-init files #7396

merged 1 commit into from
Aug 30, 2024

Conversation

Nino-K
Copy link
Member

@Nino-K Nino-K commented Aug 30, 2024

This replaces the wsl-init for wsl-init-rd-networking since we no longer have the option to toggle between networking options.

Fixes: #7395

This replaces the wsl-init for wsl-init-rd-networking
since we no longer have an option to toggle between
networking options.

Signed-off-by: Nino Kodabande <nkodabande@suse.com>
@mook-as mook-as self-requested a review August 30, 2024 16:50
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have been much easier to review if it was done as a remove of the old file in one commit, and then moving the new file to the old name in a separate commit. But it seems to be fine. (I basically did that locally to confirm that the new ws-init contained the old contents of wsl-init-rd-networking.)

@mook-as mook-as merged commit 016c9e7 into main Aug 30, 2024
27 checks passed
@mook-as mook-as deleted the combine-wsl-init branch August 30, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine both WSL_INIT_SCRIPT and WSL_INIT_RD_NETWORKING_SCRIPT
2 participants