Change veth pair ip #7459
Merged
Change veth pair ip #7459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nino-K
force-pushed
the
change-veth-pair-ip
branch
from
f2e019a
to
60c1492
Compare
mook-as
reviewed
Sep 12, 2024
| @@ -37,7 +37,7 @@ var ( | |||
| const ( | |||
| defaultLogPath = "/var/log/wsl-proxy.log" | |||
| defaultSocket = "/run/wsl-proxy.sock" | |||
| bridgeIPAddr = "192.168.1.2" | |||
| bridgeIPAddr = "192.168.143.2" | |||
There was a problem hiding this comment.
So if I understand this correctly, it used to talk to the namespace veth, but it now talks to the WSL veth?
There was a problem hiding this comment.
Yeah, this is the wrong address; it needs to talk to the namespace veth instead.
time="2024-09-12T12:16:30-07:00" level=debug msg="received the following port: [80] from portMapping: {Remove:false Ports:map[80/tcp:[{HostIP:0.0.0.0 HostPort:80}]] ConnectAddrs:[]}"
time="2024-09-12T12:16:56-07:00" level=debug msg="port proxy accepted connection from 127.0.0.1:53706"
time="2024-09-12T12:16:56-07:00" level=error msg="Failed to dial upstream 192.168.143.2:80: dial tcp 192.168.143.2:80: connect: connection refused"
# curl --head 192.168.143.1
HTTP/1.1 200 OK
Server: nginx/1.26.2
Date: Thu, 12 Sep 2024 19:18:38 GMT
Content-Type: text/html
Content-Length: 615
Last-Modified: Mon, 12 Aug 2024 14:28:31 GMT
Connection: keep-alive
ETag: "66ba1c0f-267"
Accept-Ranges: bytes
There was a problem hiding this comment.
Yes, I missed the last octet.
mook-as
requested changes
Sep 12, 2024
I toggled the veth pair around, I will rename it for clarity. |
Nino-K
force-pushed
the
change-veth-pair-ip
branch
from
60c1492
to
69ec712
Compare
mook-as
requested changes
Sep 12, 2024
src/go/networking/README.md
Outdated
| @@ -47,7 +47,7 @@ portForwarding["Port Forwarding"] | |||
| `host-switch` runs on the Windows host and acts as a receiver for all traffic originating from the network namespace within the WSL VM. It performs a handshake to find the right VM to talk to over `AF_VSOCK`. Once a correct VM is found, it then listens for the incoming traffic from that VM. In addition to this, it can provide a DNS resolver that runs in the user space network along with an API that allows for dynamic port forwarding. | |||
|
|
|||
| ## network-setup | |||
| Its main responsibility is to respond to the handshake request from the `host-switch.exe`, create a network namespace and start the `vm-switch` subprocess in the newly created network namespace. In addition, it also calls unshare with provided arguments through `--unshare-args`. Below is a sequence diagram demonstrating the process. The process also establishes a Virtual Ethernet pair consisting of two endpoints: `veth-rd0` and `veth-rd1`. `veth-rd0` resides within the default namespace and is configured to listen on the IP address `192.168.1.1`. Conversely, `veth-rd1` is located within a network namespace and is assigned the IP address `192.168.1.2`. | |||
| Its main responsibility is to respond to the handshake request from the `host-switch.exe`, create a network namespace and start the `vm-switch` subprocess in the newly created network namespace. In addition, it also calls unshare with provided arguments through `--unshare-args`. Below is a sequence diagram demonstrating the process. The process also establishes a Virtual Ethernet pair consisting of two endpoints: `veth-rd0` and `veth-rd1`. `veth-rd1` resides within the WSL's default namespace and is configured to listen on the IP address `192.168.143.2`. Conversely, `veth-rd0` is located within a network namespace and is assigned the IP address `192.168.143.1`. | |||
There was a problem hiding this comment.
veth-* names need to be changed here.
Nino-K
force-pushed
the
change-veth-pair-ip
branch
from
69ec712
to
7d5e127
Compare
Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Nino-K
force-pushed
the
change-veth-pair-ip
branch
from
7d5e127
to
8ad4663
Compare
mook-as
previously approved these changes
Sep 12, 2024
Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Nino-K
force-pushed
the
change-veth-pair-ip
branch
from
8ad4663
to
1e90eef
Compare
mook-as
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the IP Addresses for the veth pair to reduce collision with users' existing network.
Fixes: #7383